124 replies to this topic

[123]

grantlewis, on 07 Feb 2019 - 13:58, said:

Looks like 0.87.0 only makes matters worse. In addition to the loss of thermostat control, 16 OmniPro flags, which were previously operating as switches in 0.84.6, are unrecognized.

...
  File "/usr/local/lib/python3.6/site-packages/homeassistant/components/mqtt/switch.py", line 66, in async_discover
...
voluptuous.error.MultipleInvalid: extra keys not allowed @ data['brightness_state_topic']

Hmm. What's that all about? MQTT Switch does not even support brightness_state_topic. It's MQTT Light that supports it.
https://www.home-ass...ess_state_topic


I wonder if it has anything to do with this breaking change in 0.87:

Quote
MQTT platforms will now flag mistyped configs from configuration.yaml correctly as invalid, instead of just ignoring them. (@emontnemery - #20562) (mqtt docs) (breaking change)

In other words, in previous releases, if you included an invalid MQTT parameter (like specifying a brightness_state_topic for a switch component), it would simply be ignored. As of 0.87, it no longer ignores them.

Edited by 123, 08 February 2019 - 03:54 PM.

[rsw686]

Hmm. What's that all about? MQTT Switch does not even support brightness_state_topic. It's MQTT Light that supports it.
https://www.home-ass...ess_state_topic


I wonder if it has anything to do with this breaking change in 0.87:

In other words, in previous releases, if you included an invalid MQTT parameter (like specifying a brightness_state_topic for a switch component), it would simply be ignored. As of 0.87, it no longer ignores them.

 

I'm working on fixing this right now. Yes it has to do with the breaking change you noted. I was mapping units < 385 to light and units >= 385 (outputs) to switches. However I used the same config generator, which Home Assistant just ignored the extra values until now.

[rsw686]

I just released version 1.1.3 of OmniLinkBridge on GitHub, which fixes the above issue. Additionally I've updated my branches for the Home Assistant custom_components. Please note that Home Assistant moved them from climate and alarm_control_panel directories to mqtt. If you have the previous versions you will need to delete the old ones from your custom_components directory.

 

https://raw.githubus...mqtt/climate.py

https://raw.githubus...ontrol_panel.py

 

I'm going to try again to get the custom_component changes merged into Home Assistant's code base.

[grantlewis]

Great work! Thank you.

Edited by grantlewis, 10 February 2019 - 08:58 PM.

[pete_c]

Updated today to HA 87.1.  Running fine.  I am impressed with the changes I see.

 

Updated OmniLinkBridge to version 1.1.3.

 

Thank you Ryan!